[core] desc.node: Support the use of custom Python executables for meshroom_compute
#2849
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cbentejac
changed the title
meshroom_compute
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #2849 +/- ##
========================================
Coverage 79.08% 79.08%
========================================
Files 51 51
Lines 6889 6889
========================================
Hits 5448 5448
Misses 1441 1441 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
cbentejac
force-pushed
the
dev/pythonExecutable
branch
from
df79133 to
926ce7b
Compare
cbentejac
force-pushed
the
dev/improveSetup
branch
from
8514fd0 to
a946bc7
Compare
cbentejac
force-pushed
the
dev/pythonExecutable
branch
from
926ce7b to
57e9b8e
Compare
cbentejac
force-pushed
the
dev/pythonExecutable
branch
from
57e9b8e to
a356b8e
Compare
cbentejac
requested review from
Alxiice,
demoulinv,
fabiencastan and
servantftransperfect
cbentejac
force-pushed
the
dev/pythonExecutable
branch
from
a356b8e to
9152205
Compare
…ute` If `pythonExecutable` has not been explicitly set in the node's description, then the default `python` will be used. Otherwise, the one set in the description will be used. `_MESHROOM_COMPUTE_EXE` is removed since it is now impossible to determine it outside of the node.
cbentejac
force-pushed
the
dev/pythonExecutable
branch
from
9152205 to
011cc0c
Compare
Alxiice
approved these changes
Sep 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR updates how the
meshroom_computeexecutable is determined and invoked for each node, allowing for node-specific Python executables instead of using a global default. This provides greater flexibility for nodes that may require different Python environments: for example, in an environment that contains Houdini (which provides its own version of Python), one may want to call "hython" instead "python".A
pythonExecutablemember, set by default to "python", is added to theNodeclass.This is based on #2853, which adds the content of the
binfolder to the packaged version of folder, thus removing the need to distinguish "release mode" from "regular mode".